Review main Abandoned

62307[TASK] Instantiate log manager after service container

Alexander Schnitzler CR 0 V 0 Normal +122 −45 updated 11/23/19, 14:05

Commit message

Very early in the bootstrap, the LogManager has been manually
created because it was needed during the instatiation of both
the error and exception handler because they do log errors via
the standard log api. This made it impossible to configure the
log manager and therefore the whole logging via DI.

This patch moves the initialization of the log manager, the error
and exception handler after the creation of the services container.
The late instantiation of the error and exception handler mean
that all errors and exceptions that happen during the bootstrap
until the creation of the handlers or not handled by the handlers
of course. To minimize the negative impact of that, display_errors
is still set early in the bootstrap.

It's worth noting that while there is no custom error handler
registered, the native error handler of PHP is handling errors
according to the error level set via error_reporting in php.ini.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2