Review main Merged

62314[BUGFIX] Fix PHP error in SoftReferenceParserHook for missing form definitions

Stephan Großberndt CR +2 V +2 Easy +5 −0 updated 11/21/19, 16:13

Commit message

This patch adds a safe guard to make sure the `$file` object is not null
on trying to update the soft reference. This is necessary as
`ResourceFactory->retrieveFileOrFolderObject()` returns null instead of
throwing an exception in several cases (e.g. missing form definition
located in an extension).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1