Review main Merged

62342[BUGFIX] Always allow dividers in TCA auth mode check

Alexander Stehlik CR +2 V +2 Normal +79 −0 updated 12/15/19, 16:17

Commit message

This brings back the optgroups in the CType and list_type fields
for normal editors.

Additionally some tests for checkAuthMode are added.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 813

  1. Alexander Stehlik uploaded patch set 1 11/18/19, 19:10

  2. TYPO3com voted on patch set 1 V -1 11/18/19, 19:11 Completed build in 12s on Mon, 18 Nov, 07:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38465

  3. Alexander Stehlik uploaded patch set 2 11/18/19, 19:16

  4. TYPO3com voted on patch set 2 V -1 11/18/19, 19:23 Completed build in 06m 59s on Mon, 18 Nov, 07:23 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38466

  5. Alexander Stehlik uploaded patch set 3 11/18/19, 19:39

  6. TYPO3com commented on patch set 3 11/18/19, 19:46 Completed build in 07m 20s on Mon, 18 Nov, 07:46 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38467

  7. Alexander Stehlik rebased onto patch set 4 11/19/19, 12:19

  8. TYPO3com voted on patch set 4 V -1 11/19/19, 12:26 Completed build in 06m 47s on Tue, 19 Nov, 12:26 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38474

  9. TYPO3com voted on patch set 4 V +1 11/19/19, 14:19 Completed build in 07m 19s on Tue, 19 Nov, 02:19 PM Test Summary: 48376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38482

  10. Susi Moog voted on patch set 4 CR +1 12/15/19, 16:10

  11. Susi Moog voted on patch set 4 V +1 12/15/19, 16:16

  12. Daniel Goerz voted on patch set 4 V +2 CR +2 12/15/19, 16:17

  13. Daniel Goerz merged patch set 5 12/15/19, 16:17