Review main Merged

62343[TASK] Avoid processing empty entity ids in DataMapProcessor

Oliver Hader CR +2 V +2 Easy +13 −1 updated 11/19/19, 13:31

Commit message

Avoid executing (more expensive) queries in DataMapProcessor in case
there are actually no entity ids to be retrieved from database.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 11/19/19, 10:43

  2. TYPO3com voted on patch set 1 V +1 11/19/19, 10:50 Completed build in 07m 04s on Tue, 19 Nov, 10:50 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38470

  3. Oliver Hader updated the commit message in patch set 2 11/19/19, 10:56

  4. TYPO3com voted on patch set 2 V +1 11/19/19, 11:03 Completed build in 07m 12s on Tue, 19 Nov, 11:03 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38471

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/19/19, 13:11

  6. Daniel Gorges voted on patch set 2 V +1 CR +1 11/19/19, 13:22

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/19/19, 13:31

  8. Benni Mack merged patch set 3 11/19/19, 13:31