Review main Merged

62365[BUGFIX] Ensure hoa/core is not a dependency

Benni Mack CR +2 V +2 Easy +3 −4 updated 11/22/19, 09:58

Commit message

When running composer update --prefer-lowest
the abandoned package hoa/core could still
be installed via codeception/codeception,
which in turn results in issues running
our test suite.

See https://github.com/hoaproject/Protocol/issues/8

This is also needed for PHP 7.4 compatibility.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3