Review main Merged

62418[TASK] Follow-up: Introduce native pagination for lists

Alexander Schnitzler CR +2 V +2 Easy +25 −23 updated 11/23/19, 14:52

Commit message

- Switch the order of constructor arguments $currentPageNumber
  and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator
  classes as the $currentPageNumber needs to be set on every object
  construction whereas the $itemsPerPage argument only needs to be
  changed for paginators that use a differen amount of items per page
  other than the default of 10.
- Change visibility of properties of both the ArrayPaginator and the
  QueryResultPaginator from protected to private as both classes are
  marked final.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5