Review main Merged

62422[FEATURE] Migrate various Signals to PSR-14 events in system extensions

Benni Mack CR +2 V +2 Expert +1663 −256 updated 12/02/19, 11:02

Commit message

The following new PSR-14 events are added:

TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent
TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent
TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent
TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent
TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent
TYPO3\CMS\Impexp\Event\BeforeImportEvent
TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent
TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent
TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent
TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent
TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent

They replace the following "old" signals with a deprecation layer:

TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer
TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter
TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter
TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude
TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser
TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation
TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl
TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord
TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 48

Show 28 more files