Review main Merged

62427[BUGFIX] Fix compatibility with symfony/dependency-injection:5.0

Benjamin Franzke CR +2 V +2 Easy +32 −7 updated 11/27/19, 21:31

Commit message

The recently released symfony 4.4 introduced a deprecation for
non-object services and so 5.0 dropped support.
That means we run into exception with symfony 5.0 when
we add synthetic non-object services. Symfony 5.0 contains
a type declaration that allows for objects only:

Argument 2 passed to
Symfony\Component\DependencyInjection\Container::set()
must be an object or null, bool given, called in
[…]/typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php
on line 99
at
Symfony\Component\DependencyInjection\Container->set(
    '_early.env.is_unix',
    true
)

We provided four boolean services in v10.0 but never used
or documented these in core, therefore we drop them now:
 - env.is_unix
 - env.is_windows
 - env.is_cli
 - env.is_compoer_mode

These variales can actually be substitued by using dynamic
environment parameters (those are supported thanks to our
EnvVarProcessor):

 - "%env(TYPO3:isUnix)%"
 - "%env(TYPO3:isWindows)%"
 - "%env(TYPO3:isCli)%"
 - "%env(TYPO3:isComposerMode)%"

One more, internally used, boolean service is now migrated into
the internal boot.state service:

 - cache.disabled

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3