Review main Merged

62429[TASK] Use ArrayObject for middleware storage in symfony container

Benjamin Franzke CR +2 V +2 Normal +45 −38 updated 11/29/19, 10:34

Commit message

Symfony 4.4 deprecated support for non-object services:
https://github.com/symfony/dependency-injection/commit/6f11b359ab9

The usage of `array` as service is therefore no longer officially
supported in Symfony 5.0. It still works, but in order to make
sure that a possibly introduced type declaration in a 5.x release
doesnt causes a type error, we migrate the middleware service
from array to ArrayObject.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9