Review 9.5 Merged

62463Revert "[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable"

Benjamin Franzke CR +2 V +2 Easy +2 −4 updated 12/06/19, 12:31

Commit message

This reverts commit 26c9a8e32637d506249989318941c923171b7658.

The schedulers *primary* task is to *schedule* tasks, not to execute them
from the backend. The backend-execution is only an additional
functionality, which is available because it's sometime handy for manual
tasks/testing.

We shouldn't mark commands as non-schedulable when scheduling them is a
perectly valid usecase.
Usecases for scheduling backend locks are:
* Planned maintenance locks:
  schedule a backend lock for a planned update or migration where you
  agreed to stop editing as of a certain date.
* Regular edit-locks, e.g.:
  schedule a backend lock for let's say every friday as of 8pm
  schedule backend unlock on mondays at 8am.

The reverted patch tried to fix the situation where the lock task was
executed from the backend scheduler overview. If we'd want to fix that,
the proper fix would be to add another property which states that this
command must not be executed from the backend.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1