Review main Merged

62496[BUGFIX] Use RequestFactory for downloading mirrors and check response properly

Andreas Kienast CR +2 V +2 Normal +51 −19 updated 12/06/19, 11:34

Commit message

The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.

In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1