Review main Merged

62518[BUGFIX] Avoid resolving default values of static property in ClassSchema

Oliver Hader CR +2 V +2 Easy +19 −1 updated 12/03/19, 08:53

Commit message

Building reflection cache in ClassSchema on static class properties will
lead to side-effects. For instance when ConnectionPool is analyzed for
being used with Extbase dependency injection and has been used already
during runtime - which is very likely - static property $connections is
going to hold all runtime connections.

https://www.php.net/manual/en/reflectionclass.getdefaultproperties.php:
> This method only works for static properties when used on internal
> classes. The default value of a static class property can not be
> tracked when using this method on user defined classes.

That's why default values of static properties are not resolved anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3