Review main Merged

62531[TASK] Implicitly add backend routes to router using DI factories

Benjamin Franzke CR +2 V +2 Normal +90 −57 updated 01/31/20, 09:53

Commit message

All Routes.php information for Backend routes are now collected
via Dependency Injection.

That means Bootstrap::initializeBackendRouter() doesn't
need to be called explicitly from a middleware anymore.

The Router class will always have the routes populated
whenever it is initialized / needed.

We use DI factories to collect and add the backend routes.
The routes from the extension configuration files are still cached,
but the cache is managed by a service provider.

We adapt the ServiceProviderCompilationPass to keep track
of the return type of extended services where the extension
may not have a return type declaration (because of the
dynamic closures in PseudoServiceProvider). We do that
to properly notify symfony DI that the routes are
stored as ArrayObject.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7