Review main Abandoned

62607[WIP][BUGFIX] Content-slide for localized content on non-localized pages

Markus Klösges CR 0 V 0 Normal +139 −0 updated 08/06/24, 15:22

Commit message

This adds a functional test showing the incorrect behavior laid out in
the issue.
It should give a starting point for fixing the behavior

I'm totally unfamiliar with the localization testing stuff, so this
test can probably be simplified using the yaml fixtures, and integrated
into some other test-class.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1423

  1. Markus Klösges uploaded patch set 1 12/12/19, 13:45

  2. TYPO3com voted on patch set 1 V -1 12/12/19, 14:48 Completed build in 1h 03m 14s on Thu, 12 Dec, 02:48 PM Test Summary: 4 of 69179 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39362

  3. Benni Mack updated the commit message in patch set 2 05/25/20, 18:41

  4. TYPO3com voted on patch set 2 V -1 05/25/20, 18:49 Completed build in 33s on Mon, 25 May, 06:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3525

  5. Benni Mack updated the commit message in patch set 3 11/11/21, 14:11

  6. Stefan Bürk uploaded patch set 4 11/13/21, 09:37

  7. Stefan Bürk updated the commit message in patch set 5 11/13/21, 09:38

  8. Stefan Bürk commented on patch set 5 11/13/21, 09:46

    Updated tests to be generally workable in current master. One test case fails, but as I understand this was intended. At least that testcase matches the expectation of issue creator, so I would guess for now that it's okay (for now) that this dataset fails to show that there is an error.
  9. core-ci voted on patch set 4 V -1 11/13/21, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19218

  10. core-ci voted on patch set 5 V -1 11/13/21, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19219

  11. Nikita Hovratov uploaded patch set 6 11/13/21, 10:50

  12. core-ci voted on patch set 6 V -1 11/13/21, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19222

  13. Benni Mack uploaded patch set 7 11/18/21, 14:39

  14. core-ci voted on patch set 7 V -1 11/18/21, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19514

  15. Stefan Bürk commented on patch set 8 11/18/21, 15:48

    Published edit on patch set 7.
  16. core-ci voted on patch set 8 V -1 11/18/21, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19521

  17. Stefan Bürk commented on patch set 9 11/18/21, 15:51

    Published edit on patch set 8.
  18. core-ci voted on patch set 9 V -1 11/18/21, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19522

  19. Benni Mack wrote 11/29/21, 10:21

    Change destination moved from master to main
  20. Benni Mack updated the commit message in patch set 10 11/29/21, 14:10

  21. core-ci voted on patch set 10 V -1 11/29/21, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20109

  22. Benni Mack updated the commit message in patch set 11 V -1 05/03/23, 09:53

  23. Benni Mack abandoned the change 08/06/24, 15:22

    Abandoning this change due to lack of adaption