Review main Merged

62624[TASK] Move constant declaration to class constants

Benni Mack CR +2 V +2 Hard +198 −64 updated 01/10/20, 14:07

Commit message

Using Class constants instead of constants that are defined during
runtime has the following benefits:

- Naming can be made more consistent (and separated)
- Speeding up requests where the constants are not needed
- Benefit from Opcaching of class loading instead of dynamic runtime definition
- Testing framework has less "bootstrap" to do

This affects the following constants:
- TYPO3_copyright_year
- TYPO3_URL_GENERAL
- TYPO3_URL_LICENSE
- TYPO3_URL_EXCEPTION
- TYPO3_URL_DONATE
- TYPO3_URL_WIKI_OPCODECACHE

The constants are now deprecated.

In addition, the "Typo3Copyright" class is now called "TYPO3Information".

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 20