Review 9.5 Merged

62661[BUGFIX] Adjust parameters of implode() for PHP 7.4

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 12/27/19, 21:10

Commit message

The TimeTracker has been using the wrong order of glue
and pieces, the PageLayoutView has used implode with only
one parameter. Both occurences have been adjusted.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Andreas Kienast commented on patch set 1 12/19/19, 06:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/19/19, 06:39 Completed build in 11m 53s on Thu, 19 Dec, 06:39 AM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1743

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 12/19/19, 06:44

  4. Andreas Kienast merged patch set 2 12/19/19, 06:44

  5. Oliver Hader voted on patch set 2 CR +1 12/27/19, 21:10