Review TYPO3_8-7 Merged

62695[SECURITY] Avoid possible insecure deserialization in Extbase

Oliver Hader CR +2 V +2 Easy +3 −3 updated 12/17/19, 10:38

Commit message

Albeit requests to Extbase's property mapper won't be processed
in case the required cryptographic hash is not given or invalid
(as HMAC-SHA1 on payload having TYPO3 encryptionKey as secret),
a leaked encryptionKey (e.g from backup files, pushed to public
repository by accident) would allow insecure deserialization.

TYPO3 v10 is using json_decode instead of unserialize which was
not feasible in existing LTS branches due to potential backward
compatibility side-effects.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2