Review main Merged

62745[BUGFIX] Adjust parameters of implode() for PHP 7.4

Susi Moog CR +2 V +2 Easy +3 −3 updated 12/27/19, 21:09

Commit message

The TimeTracker has been using the wrong order of glue
and pieces, the PageLayoutView has used implode with only
one parameter. Both occurences have been adjusted.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Susi Moog uploaded patch set 1 12/18/19, 17:42

  2. TYPO3com voted on patch set 1 V +1 12/18/19, 17:51 Completed build in 08m 29s on Wed, 18 Dec, 05:51 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39516

  3. Oliver Klee voted on patch set 1 CR +1 12/18/19, 18:15

  4. Georg Ringer voted on patch set 1 V +1 CR +1 12/18/19, 21:21

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 12/19/19, 06:27

  6. Andreas Kienast merged patch set 2 12/19/19, 06:27

  7. Oliver Hader voted on patch set 2 V +1 CR +1 12/27/19, 21:09