Review main Merged

62763[TASK] Clean up Page Permission handling in DataHandler

Benni Mack CR +2 V +2 Hard +357 −35 updated 12/31/19, 11:57

Commit message

TYPO3's page permissions are based on five fields and a bitset.

- perms_userid
- perms_groupid
- perms_user
- perms_group
- perms_everybody

For permissions of a page there is
- show page ("show")
- edit page properties ("edit page")
- edit page contents / records ("edit content")
- delete page ("delete")
- create new subpages ("new")

In addition, these can be pre-set globally or via PageTSconfig.

The DataHandler currently uses a mix between strings and integers
for defining these values.

A new PagePermissionAssembler class builds together the page permissions
now, allowing to thin out certain parts of DataHandlers responsibility.

The following properties and methods are now deprecated:
- DataHandler->defaultPermissions
- DataHandler->pMap
- DataHandler->setTSconfigPermissions()
- DataHandler->assemblePermissions()

The methods
- DataHandler->doesRecordExist()
- DataHandler->recordInfoWithPermissionCheck()
should only be called with integers as permission argument in the future.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8