Review main Abandoned

62779[BUGFIX] Wrong default language when languages not ordered ascending

Mario Lubenka CR 0 V 0 Normal +104 −0 updated 12/04/24, 16:09

Commit message

Sort languages by id and move the id = 0 (default language) to first position.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 2535

Show 610 earlier messages
  1. Mario Lubenka uploaded patch set 1 12/29/19, 02:35

  2. Mario Lubenka uploaded patch set 2 12/29/19, 02:40

  3. TYPO3com voted on patch set 1 V +1 12/29/19, 02:45 Completed build in 10m 27s on Sun, 29 Dec, 02:45 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39643

  4. TYPO3com voted on patch set 2 V -1 12/29/19, 03:00 Completed build in 16m 26s on Sun, 29 Dec, 03:00 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39644

  5. Jörg Bösche uploaded patch set 3 01/16/20, 09:40

  6. Jörg Bösche uploaded patch set 4 01/16/20, 09:41

  7. Jörg Bösche uploaded patch set 5 01/16/20, 09:48

  8. Jörg Bösche uploaded patch set 6 01/16/20, 09:50

  9. TYPO3com voted on patch set 3 V -1 01/16/20, 09:52 Completed build in 12m 19s on Thu, 16 Jan, 09:52 AM Test Summary: 70361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40007

  10. TYPO3com voted on patch set 4 V +1 01/16/20, 10:00 Completed build in 17m 52s on Thu, 16 Jan, 10:00 AM Test Summary: 70361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40008

  1. TYPO3com voted on patch set 6 V +1 01/16/20, 10:06 Completed build in 15m 14s on Thu, 16 Jan, 10:06 AM Test Summary: 70361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40010

  2. TYPO3com voted on patch set 5 V +1 01/16/20, 10:14 Completed build in 22m 52s on Thu, 16 Jan, 10:14 AM Test Summary: 70361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40009

  3. Steffen Frese voted on patch set 6 V +1 CR +1 01/16/20, 12:36

  4. Sascha Rademacher voted on patch set 6 V +1 CR +1 01/16/20, 12:38

  5. Felix P. voted on patch set 6 CR +1 01/16/20, 13:12

  6. Benni Mack commented on patch set 6 CR -2 01/16/20, 13:21

    The existing code was done by design, I think we need another fix.
  7. Jörg Bösche uploaded patch set 7 01/16/20, 15:15

  8. TYPO3com voted on patch set 7 V -1 01/16/20, 15:27 Completed build in 11m 38s on Thu, 16 Jan, 03:27 PM Test Summary: 70363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40050

  9. Mario Lubenka commented on patch set 7 01/16/20, 17:52

    SiteConfigurationTest.php:122 Unresolved

    I think the test `writingOfNestedStructuresPreservesOrder` should be restored here.
  10. Jörg Bösche uploaded patch set 8 01/17/20, 06:30

  11. TYPO3com voted on patch set 8 V -1 01/17/20, 06:39 Completed build in 08m 48s on Fri, 17 Jan, 06:39 AM Test Summary: 70146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40057

  12. TYPO3com voted on patch set 8 V +1 01/17/20, 06:57 Completed build in 09m 14s on Fri, 17 Jan, 06:57 AM Test Summary: 70448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40058

  13. Tobi Kretschmann voted on patch set 8 CR +1 01/17/20, 07:02

  14. Tobi Kretschmann voted on patch set 8 V +1 01/17/20, 07:15

  15. Benni Mack updated the commit message in patch set 9 05/25/20, 18:42

  16. TYPO3com voted on patch set 9 V +1 05/25/20, 19:18 Completed build in 28m 53s on Mon, 25 May, 07:18 PM Test Summary: 73814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3528

  17. Jörg Bösche voted on patch set 9 V +1 CR +1 08/28/20, 09:43

  18. Benni Mack commented on patch set 9 CR -2 11/10/21, 11:49

    should we just sort the "0" on the very first part, not when dealing with the yaml, but when fetching Site->getDefaultLanguage() ?
  19. Benni Mack updated the commit message in patch set 10 11/18/21, 10:46

  20. Benni Mack wrote 11/29/21, 10:16

    Change destination moved from master to main
  21. Benni Mack updated the commit message in patch set 11 11/29/21, 14:02

  22. Benni Mack updated the commit message in patch set 12 05/03/23, 09:03

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  23. Benni Mack updated the commit message in patch set 13 10/18/24, 14:05

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  24. Rafael Kähm commented on patch set 13 CR -1 V -1 12/02/24, 10:58

    Please don't do that. We do not want side-effects like that. Also please no re-sorting of defined stuff at all. Would propose to add a hint in the docs, instead of that. If possible a mark(default) in Sites module on first defined language.
  25. Mario Lubenka abandoned the change 12/04/24, 16:09

    Approach does not make sense