Review 9.5 Merged

62801[BUGFIX] Ensure fresh logger instance in scheduler tasks

Benni Mack CR +2 V +2 Easy +13 −29 updated 01/10/20, 10:02

Commit message

The AbstractTask always had methods setScheduler and
unsetScheduler to avoid serialization of the scheduler instance.
These methods are called by the scheduler API before serializing
(unset) and after unserializing (set).

Use these methods in favor of the __sleep and __wakup calls
to avoid issues with third party subclasses that implement these methods
and to make sure tasks that are already serialized with an outdated
logger instance are properly updated on next run without the need
to clean them up manually.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3