Review main Abandoned

62825[BUGFIX] Do not ignore array-like site configuration values

Claus Due CR 0 V 0 Easy +5 −6 updated 12/08/21, 21:40

Commit message

This patch removes an intentional exclusion of any
and all array-like values stored in site-configuration
YAML files and replaces a redundant loop with
array union.

Ignoring such values causes any multi-option select
field to be inoperable in site configuration pseudo-TCA,
since after saving the values, the field will not be
rendered with selected options. The field always appears
to have no selected values.

This in turn causes multi-option select fields to be
inoperable in site-configuration since any reload of the
form causes already selected options to be no longer
selected, which then empties the field value on save.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2