Review 9.5 Merged

62976[BUGFIX] Reduce memory consumption in findIdentifiersByTag()

Susi Moog CR +2 V +2 Easy +9 −21 updated 01/24/20, 17:15

Commit message

When searching cache-identifiers by tag, the Typo3DatabaseBackend now
utilizes DBMS functions for de-duplication of identifiers instead
of fetching all records and de-duplicate them afterwards in php space.
This dramatically reduces memory usage, when many duplicated identifiers
are in a cache table for any given tag.
Note that there is no noticable impact whenever there are no duplicates
at all, as the DBMS handles the de-duplication.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Susi Moog commented on patch set 1 01/24/20, 16:53

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/24/20, 17:13 Completed build in 15m 52s on Fri, 24 Jan, 05:13 PM Test Summary: 73979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1907

  3. Susi Moog commented on patch set 1 V +2 CR +2 01/24/20, 17:15

    straight backport.
  4. Susi Moog merged patch set 2 01/24/20, 17:15