Review main Merged

63067[TASK] Simplify code of FileList module

Benni Mack CR +2 V +2 Hard +250 −568 updated 02/03/20, 08:08

Commit message

The FileList class was originally a derivative of DatabaseRecordList,
which was decoupled in TYPO3 v9 and and marked as internal.

It is responsible for showing the actual "FileList" in the TYPO3 Backend
module.

A lot of this code has grown historically, and can be removed and
simplified, as it is not directly connected to the abstract record list anymore.

This patch removes unused public properties like $JScode as this is
part of a "multi-table" setup as is possible in the database listings.

Some methods are split into smaller parts to make the methods
themselves smaller.

This is however just the first step, next to separating the curation
and the output (and moving this into a fluid template), also using proper pagination
for fetching files and folders, or building DI for the class now is much easier to do.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2