Review main Merged

63073[BUGFIX] Use direct method calls for backend layouts in Page Module

Benni Mack CR +2 V +2 Easy +4 −2 updated 01/31/20, 11:59

Commit message

Within all refactorings, fetching the correct backend layout and relevant colPos
information was still called via callUserFunction which is not needed at all,
as it is a static information (class + method name) so a regular method call
via PHP works just fine.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Benni Mack uploaded patch set 1 01/30/20, 07:34

  2. TYPO3com voted on patch set 1 V +1 01/30/20, 08:05 Completed build in 14m 49s on Thu, 30 Jan, 08:05 AM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40347

  3. Oliver Klee voted on patch set 1 CR +1 01/30/20, 08:26

  4. Benni Mack updated the commit message in patch set 2 01/30/20, 08:55

  5. TYPO3com voted on patch set 2 V +1 01/30/20, 09:14 Completed build in 19m 36s on Thu, 30 Jan, 09:14 AM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40348

  6. Oliver Klee voted on patch set 2 CR +1 01/30/20, 16:05

  7. Georg Ringer voted on patch set 2 V +1 CR +1 01/30/20, 20:03

  8. Oliver Hader voted on patch set 2 V +2 CR +2 01/30/20, 20:55

  9. Oliver Hader merged patch set 3 01/30/20, 20:56

  10. Claus Due commented on patch set 3 01/31/20, 11:58

    I'd like to request that we all become a bit more conservative about changing method signatures when it is not strictly required to do so.
  11. Claus Due commented on patch set 3 01/31/20, 11:59

    > Patch Set 3: > > I'd like to request that we all become a bit more conservative about changing method signatures when it is not strictly required to do so. Sry, wrong patch. Comment intended for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069. Please disregard!