Review main Merged

63076[TASK] Replace ResourceFactory::getInstance() with makeInstance

Benni Mack CR +2 V +2 Hard +167 −88 updated 01/30/20, 21:31

Commit message

The so-called "singleton factory instance" is a wrapper around makeInstance
which can be used directly anyways.

With Dependency Injection this is not even necessary anymore, and should
be avoided under all circumstances.

The constructor does not cache anything, so this can be replaced completely.

SingletonInterface + DI should be sufficient already.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 62

Show 42 more files