Review main Merged

63094[TASK] Restore public and non-internal method signatures

Claus Due CR +2 V +2 Easy +10 −6 updated 01/31/20, 13:30

Commit message

Followup for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069

The original patch changed both public and non-internal
method signatures and constitutes a breaking change,
but was not committed and documented as a breaking
change. This patch restores the method signatures in
accordance with the non-breaking nature of the original
patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Claus Due uploaded patch set 1 01/31/20, 12:25

  2. Claus Due uploaded patch set 2 01/31/20, 12:31

  3. Susi Moog commented on patch set 2 01/31/20, 12:32

    PageLayoutView.php:57 Unresolved

    the class is marked as internal, so this change is imho unnecessary.
  4. TYPO3com voted on patch set 1 V +1 01/31/20, 12:45 Completed build in 18m 07s on Fri, 31 Jan, 12:45 PM Test Summary: 71164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40402

  5. TYPO3com voted on patch set 2 V +1 01/31/20, 12:48 Completed build in 12m 29s on Fri, 31 Jan, 12:48 PM Test Summary: 71164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40403

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/31/20, 13:30

  7. Benni Mack merged patch set 3 01/31/20, 13:30