Review main Abandoned

63150[BUGFIX] Unhide upgrade wizards which were previously marked as "undone"

Elias Häußler CR 0 V 0 Easy +14 −7 updated 11/18/24, 16:10

Commit message

If an upgrade wizard is marked as "undone" in the backend maintenance
module, it is currently no longer visible in the backend if the upgrade
is currently not necessary. However, this makes it impossible to
interact with the wizard again as it can then no longer be reached
within the upgrade wizard modal. As the wizard is marked as "undone",
it will also no longer be visible in the list of executed wizards which
means that it is completely hidden in the upgrade wizard modal.

In order to avoid situations where those already executed upgrade
wizards get hidden for backend users, they will again be shown in the
list of available upgrades. Additionally, a notice is appended to each
wizards' title to clearly point out the redundancy of its execution.

Redundant upgrade wizards will also not be considered for the
appropriate progress bar indicating the current upgrade wizard progress.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1317

  1. Elias Häußler uploaded patch set 1 02/02/20, 21:09

  2. TYPO3com voted on patch set 1 V +1 02/02/20, 21:19 Completed build in 10m 19s on Sun, 2 Feb, 09:19 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40493

  3. Oli Bartsch commented on patch set 1 02/06/20, 07:18

    I currently don’t get the need of this patch. Is this not exactly the purpose to hide also as undone marked wizards if the execution is not necessary? This avoids as your commit message states out redundancy. Or do I got this wrong?
  4. Benni Mack updated the commit message in patch set 2 05/25/20, 18:43

  5. TYPO3com voted on patch set 2 V -1 05/25/20, 19:22 Completed build in 33m 25s on Mon, 25 May, 07:22 PM Test Summary: 1 of 74292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3531

  6. Benni Mack commented on patch set 2 10/08/21, 08:13

    ping. If there is no progress, I will abandon this change for the time being.
  7. Elias Häußler commented on patch set 2 10/08/21, 08:16

    Reply Unresolved

    Hey Benni, I'll rebase and check if the patch is still necessary in the next days.
  8. Elias Häußler uploaded patch set 3 10/08/21, 08:37

  9. Elias Häußler marked it work in progress 10/08/21, 08:38

  10. core-ci voted on patch set 3 V +1 10/08/21, 09:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17802

  11. Benni Mack wrote 11/29/21, 10:12

    Change destination moved from master to main
  12. Benni Mack updated the commit message in patch set 4 11/29/21, 13:36

  13. core-ci voted on patch set 4 V +1 11/29/21, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20051

  14. Anja Leichsenring commented on patch set 4 08/01/24, 11:23

    Hi Elias, seems we were stuck here for another year. Would you mind to make a decision and either abandon or finish the patch? Thank you.
  15. Benni Mack updated the commit message in patch set 5 V +1 10/18/24, 13:40

  16. Elias Häußler commented on patch set 5 11/18/24, 16:10

    Reply

    I'm gonna close this patch for now. I don't see any benefit in it anymore.
  17. Elias Häußler abandoned the change 11/18/24, 16:10