Review 9.5 Merged

63151[BUGFIX] Reintroduce Extbase referring argument handling

Oliver Hader CR +2 V +2 Hard +544 −1 updated 04/25/20, 12:14

Commit message

Change https://review.typo3.org/c/Packages/TYPO3.CMS/+/62702 (v9)
modified Extbase referring argument handling.

It turned out that this approach to harden security aspects had a
couple of negative side-effects (e.g. that valid objects were not
available anymore on validation failures). Thus, plain `unserialize`
for `$internalArguments['__referrer']['arguments']` is now in place
again - which still requires to be singed with a valid HMAC.

In addition to that, additional functional tests for this scenario
have been added with this changeset.

This partly reverts commit b1626ad8fd4aebedc15e424a76f86094d78b2564
(reverts `arguments`, but keeps `@request` and `__trustedProperties`)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8