Review main Merged

63156[TASK] Separate PageInformation controller from PageLayoutView

Benni Mack CR +2 V +2 Hard +394 −406 updated 02/03/20, 15:41

Commit message

In order to decouple Web->Info from Web->Layout, the PageInformationController
now contains all code that is needed to render the tree within the module.

All renderings relevant for pages are removed from PageLayoutView
and moved to PageInformationController.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 02/03/20, 10:05

  2. TYPO3com voted on patch set 1 V -1 02/03/20, 10:05 Completed build in 16s on Mon, 3 Feb, 10:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40504

  3. Benni Mack uploaded patch set 2 02/03/20, 10:19

  4. TYPO3com voted on patch set 2 V +1 02/03/20, 10:28 Completed build in 09m 33s on Mon, 3 Feb, 10:28 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40506

  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/03/20, 15:15

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 02/03/20, 15:41

  7. Andreas Kienast merged patch set 3 02/03/20, 15:41