Review main Merged

63172[TASK] Split up PageLayoutView code into smaller chunks

Benni Mack CR +2 V +2 Expert +490 −544 updated 02/10/20, 06:24

Commit message

The PageLayoutView monster class has been chunked up into smaller
parts and some other functionality was removed.

In detail this patch changes:
- start() method is removed, as it is not needed anymore
- public properties which are not in use or have been left-overs ("nextThree") are removed
- rendering a single content element is now split up into smaller parts
- rendering the "localization view" is now separated into a separate method
- unnecessary functionality in separate methods (addPageIdConstraint) is moved into the main SQL function

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3