Review main Merged

63184[BUGFIX] Allow Tree DataProviders with original constructor

Benni Mack CR +2 V +2 Easy +27 −1 updated 03/06/20, 09:13

Commit message

If a treedataprovider (e.g. from news) extends from Core's
constructor, Core hands in various multiple arguments.

However, Core is configured to only hand in one argument,
which is auto-wired. So there are multiple options:

- Third-party extensions would need to be autowiring their
signatures as well, however would never receive the EventDispatcher
object.
- Reflect on the constructor method and hand in the EventDispatcher
  manually, but also with the custom arguments as an additional argument
- throw away the custom configuration options and use setter injection
  for the options

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2