Review main Merged

63209[TASK] Remove dependency to webmozart/assert

Benni Mack CR +2 V +2 Easy +11 −15 updated 02/12/20, 20:43

Commit message

TYPO3 uses "phpdocumentor/reflection-docblock" (added in Jan 2019)
but also added "webmozart/assert" which is not needed directly (as it is
a subdependency). Thus, TYPO3 Core should only require what is directly
used, therefore the dependency is removed.

Used composer command:
  composer remove webmozart/assert

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 56

  1. Benni Mack uploaded patch set 1 02/12/20, 19:46

  2. Benni Mack updated the commit message in patch set 2 02/12/20, 19:55

  3. TYPO3com voted on patch set 1 V -1 02/12/20, 20:01 Completed build in 14m 23s on Wed, 12 Feb, 08:01 PM Test Summary: 1 of 71712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15

  4. Georg Ringer voted on patch set 2 V +1 CR +1 02/12/20, 20:13

  5. Benni Mack voted on patch set 2 V +2 CR +2 02/12/20, 20:43

  6. Benni Mack merged patch set 3 02/12/20, 20:43