Review 9.5 Merged

63226[BUGFIX] Show sys_note of hidden or deleted author

Benni Mack CR +2 V +2 Easy +18 −6 updated 02/17/20, 23:15

Commit message

Since the querybuilder is used to fetch notes the default restrictions
of both apply sys_note and be_users. This patch removes the default
restrictions and adds them manually only for sys_note. The names of
hidden or deleted authors are replaced with "unknown author" instead.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Files 3

Review log 810

  1. Benni Mack commented on patch set 1 02/15/20, 10:28

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/sys_note/Resources/Private/Templates/Note/List.html
  2. TYPO3com voted on patch set 1 V -1 02/15/20, 10:40 Completed build in 11m 45s on Sat, 15 Feb, 10:40 AM Test Summary: 1 of 74927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-31

  3. Benni Mack uploaded patch set 2 02/17/20, 22:34

  4. Benni Mack commented on patch set 2 02/17/20, 22:35

    This change is ready for review.
  5. Anja Leichsenring commented on patch set 2 V -1 02/17/20, 22:46

    I get "Author []" instead, when it was disabled.
  6. Anja Leichsenring commented on patch set 2 V +1 CR +1 02/17/20, 22:47

    sorry, that was the cache. All good.
  7. Richard Haeser voted on patch set 2 V +1 CR +1 02/17/20, 22:50

  8. TYPO3com voted on patch set 2 V +1 02/17/20, 23:14 Completed build in 40m 03s on Mon, 17 Feb, 11:14 PM Test Summary: 74345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-46

  9. Richard Haeser voted on patch set 2 V +2 CR +2 02/17/20, 23:14

  10. Richard Haeser merged patch set 3 02/17/20, 23:15