Review main Merged

63246[BUGFIX] Show sys_note of hidden or deleted author

Nikita Hovratov CR +2 V +2 Easy +18 −6 updated 02/15/20, 10:28

Commit message

Since the querybuilder is used to fetch notes the default restrictions
of both apply sys_note and be_users. This patch removes the default
restrictions and adds them manually only for sys_note. The names of
hidden or deleted authors are replaced with "unknown author" instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Files 3

Review log 79

  1. Nikita Hovratov uploaded patch set 1 02/14/20, 21:49

  2. TYPO3com voted on patch set 1 V +1 02/14/20, 22:33 Completed build in 33m 50s on Fri, 14 Feb, 10:33 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-96

  3. Stefan Froemken commented on patch set 1 V +1 CR +1 02/14/20, 22:55

    Looks good. I would change username into authorUsername. But that's only a nice to have.
  4. Nikita Hovratov uploaded patch set 2 02/15/20, 09:55

  5. Stefan Froemken voted on patch set 2 V +1 CR +1 02/15/20, 10:04

  6. Georg Ringer voted on patch set 2 V +1 CR +1 02/15/20, 10:04

  7. TYPO3com voted on patch set 2 V +1 02/15/20, 10:09 Completed build in 13m 28s on Sat, 15 Feb, 10:09 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-102

  8. Benni Mack voted on patch set 2 V +2 CR +2 02/15/20, 10:28

  9. Benni Mack merged patch set 3 02/15/20, 10:28