Review main Merged

63257[BUGFIX] Add missing use statement for SiteLanguageAwareTrait

Alexander Schnitzler CR +2 V +2 Easy +1 −0 updated 02/20/20, 08:01

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 15:15

  2. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 15:24

  3. TYPO3com voted on patch set 1 V +1 02/15/20, 15:36 Completed build in 20m 33s on Sat, 15 Feb, 03:36 PM Test Summary: 71294 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-125

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 02/15/20, 17:45

  5. Daniel Goerz merged patch set 2 02/15/20, 17:45

  6. Daniel Goerz commented on patch set 2 02/15/20, 17:49

    Hey Alex, I think 9.5 is not affected, because the error was introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893 which has not been backported. Use statements in 9.5 version of AspectFactory are fine.
  7. Alexander Schnitzler commented on patch set 2 02/15/20, 18:16

    > Patch Set 2: > > Hey Alex, I think 9.5 is not affected, because the error was introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893 which has not been backported. Use statements in 9.5 version of AspectFactory are fine. Ah, sorry for any inconveniences. I thought 9.5 would be affected as routing made it into 9. Didn't double check.
  8. Oliver Hader commented on patch set 2 02/20/20, 08:01

    → https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329 completes the back-port for introducing the interface, but considers the trait this time