Review main Merged

63258[TASK] Explicitly declare property in ConfirmationFinisher

Alexander Schnitzler CR +2 V +2 Easy +5 −0 updated 02/15/20, 17:43

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 15:19

  2. Georg Ringer commented on patch set 1 02/15/20, 15:22

    code is the same in 9.5 as well. is there a reason for skipping 9.5?
  3. Alexander Schnitzler commented on patch set 1 02/15/20, 15:24

    > Patch Set 1: > > code is the same in 9.5 as well. is there a reason for skipping 9.5? It's technically not a bug because the missing property doesn't let PHP fail. It's "fixed" in master to please phpstan.
  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 15:25

  5. TYPO3com voted on patch set 1 V +1 02/15/20, 15:42 Completed build in 15m 42s on Sat, 15 Feb, 03:42 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-126

  6. Björn Jacob voted on patch set 1 V +1 CR +1 02/15/20, 17:04

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 02/15/20, 17:42

  8. Daniel Goerz merged patch set 2 02/15/20, 17:43