Review main Merged

63262[TASK] Add missing methods in AbstractRenderable class

Alexander Schnitzler CR +2 V +2 Easy +10 −0 updated 02/16/20, 23:12

Commit message

This patch adds two methods setDefaultValue and setProperty
which are called from within class AbstractRenderable via
$this->setDefaultValue() and $this->setProperty() but are
meant to be called on a child class.

The implementation of said methods with an empty method body
only serve the purpose to please phpstan. As mentioned in
those method bodies, someone with a deeper understanding of
the form extension architecture needs to decide whether the
abstract class AbstractRenderable should only declare those
methods as abstract methods, i.e. child classes have to
implement them or if the abstract class can provide a
meaningful default behavior which can but doesn't need to
be overridden by child classes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1