Review main Merged

63274[BUGFIX] Ignore quotes in tag attribute value decoding

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 04/21/20, 16:15

Commit message

This patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62227
introduced decoding of attribute values in tags. This was necessary for
email link parameter, but broke html inside attribute tags, because
quotes were left unescaped.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 02/16/20, 21:18

  2. TYPO3com voted on patch set 1 V +1 02/16/20, 21:31 Completed build in 13m 01s on Sun, 16 Feb, 09:31 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-184

  3. Benni Mack commented on patch set 1 02/16/20, 23:06

    seems legit
  4. Benni Mack voted on patch set 1 V +1 CR +1 02/17/20, 21:50

  5. Richard Haeser voted on patch set 1 V +2 CR +2 02/17/20, 22:19

  6. Richard Haeser merged patch set 2 02/17/20, 22:19

  7. Josef Glatz commented on patch set 2 04/21/20, 16:15

    **There is a regression at least in v10.** Until https://forge.typo3.org/issues/91161 gets fixed I use following workaround which also contains pitfalls and limitations depending on your project integration and adoptions in various places: > lib.parseFunc_RTE.tags.a.typolink.title.stdWrap.htmlspecialchars=1 > lib.parseFunc_RTE.tags.a.typolink.ATagParams > This seems to be sufficient for our particular TYPO3 project