Review main Merged

63276[TASK] Ignore phpstan errors to achieve level 0 compatibility

Alexander Schnitzler CR +2 V +2 Easy +40 −4 updated 02/21/20, 14:57

Commit message

This patch ignores several errors found by phpstan which are
not easy to solve as of now or which are not solvable at all.

- Unsafe usage of new static

  Those errors can be solved in different ways. Making classes
  final, making constructors final or using new self. Which
  solution is used has to be decided by people who are familiar
  which the affected files.

- Call to an undefined method in AbstractWidgetViewHelper and
  AbstractViewHelper

  Those issues aren't solvable as those methods exist if users
  choose fluid ^3.

- Access to undefined constant TYPO3\CMS\Core\Type\Enumeration
  ::__default

  This issue can't be solved as the Enumeration class does a
  lot of magic stuff which isn't compatible with static code
  analysis.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4