Review 9.5 Merged

63293[BUGFIX] Ignore quotes in tag attribute value decoding

Richard Haeser CR +2 V +2 Easy +1 −1 updated 02/17/20, 23:22

Commit message

This patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62227
introduced decoding of attribute values in tags. This was necessary for
email link parameter, but broke html inside attribute tags, because
quotes were left unescaped.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Richard Haeser commented on patch set 1 02/17/20, 22:19

    Cherry Picked from branch master.
  2. Richard Haeser voted on patch set 1 V +1 CR +1 02/17/20, 22:32

  3. TYPO3com voted on patch set 1 V -1 02/17/20, 22:42 Completed build in 20m 05s on Mon, 17 Feb, 10:42 PM Test Summary: 1 of 74945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-44

  4. TYPO3com voted on patch set 1 V +1 02/17/20, 23:21 Completed build in 15m 23s on Mon, 17 Feb, 11:21 PM Test Summary: 74345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-47

  5. Richard Haeser voted on patch set 1 V +2 CR +2 02/17/20, 23:22

  6. Richard Haeser merged patch set 2 02/17/20, 23:22