Review main Merged

63314[BUGFIX] Prevent empty div in RecordHistory Rollback

Christian Eßl CR +2 V +2 Easy +14 −12 updated 02/19/20, 08:31

Commit message

In the RecordHistory Rollback template it can happen, that the
historyRow is missing messages about its differences. In this case, an
empty div with a weird looking border would still be visible in the
html. This patch fixes this by wrapping an if condition around the div,
that checks first, if the needed information is available.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Eßl uploaded patch set 1 02/18/20, 19:23

  2. Georg Ringer voted on patch set 1 V +1 CR +1 02/18/20, 19:39

  3. TYPO3com voted on patch set 1 V +1 02/18/20, 19:44 Completed build in 21m 42s on Tue, 18 Feb, 07:44 PM Test Summary: 71336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-264

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 02/19/20, 08:31

  5. Daniel Goerz merged patch set 2 02/19/20, 08:31