Review main Merged

63391[TASK] Introduce Argon2PasswordHashInterface

Alexander Schnitzler CR +2 V +2 Normal +42 −20 updated 02/27/20, 13:12

Commit message

This is a followup patch for the introduction of Argon2id.
https://review.typo3.org/c/Packages/TYPO3.CMS/+/63077

That commit introduced access to class constants that are
only available through late static binding. This approach
does not follow a contract and uses a bit of a magical
approach instead. It's hard to read for the user, cannot
be type checked and it is possibly unstable and may produce
unforeseen issues when inheriting AbstractArgon2PasswordHash
without defining said class constants.

To have a clean architecture with a contract driven approach
an interface is introduced which child classes of
AbstractArgon2PasswordHash have to implement. This ensures
that the algorithm in AbstractArgon2PasswordHash can
reliably fetch necessary information from the child classes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 913

  1. Alexander Schnitzler uploaded patch set 1 02/23/20, 10:58

  2. TYPO3com voted on patch set 1 V -1 02/23/20, 11:16 Completed build in 15m 42s on Sun, 23 Feb, 11:16 AM Test Summary: 1 of 72070 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-542

  3. TYPO3com voted on patch set 1 V +1 02/23/20, 11:25 Completed build in 39m 45s on Sun, 23 Feb, 11:25 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-542

  4. Alexander Schnitzler updated the commit message in patch set 2 02/23/20, 11:28

  5. TYPO3com voted on patch set 2 V +1 02/23/20, 11:48 Completed build in 16m 37s on Sun, 23 Feb, 11:48 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-545

  6. Markus Klein voted on patch set 2 CR +1 02/24/20, 09:01

  7. Markus Klein updated the commit message in patch set 3 02/24/20, 09:03

  8. Markus Klein voted on patch set 3 CR +1 02/24/20, 09:03

  9. TYPO3com voted on patch set 3 V +1 02/24/20, 09:41 Completed build in 24m 56s on Mon, 24 Feb, 09:41 AM Test Summary: 71585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-603

  10. Georg Ringer voted on patch set 3 CR +1 02/24/20, 09:58

  11. Benni Mack voted on patch set 3 V +1 CR +2 02/27/20, 11:11

  12. Susi Moog voted on patch set 3 V +2 02/27/20, 13:12

  13. Susi Moog merged patch set 4 02/27/20, 13:12