63396[TASK] Refactor extbase plugin registration
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 8
- typo3/sysext/extbase/Classes/Configuration/Exception/UniqueControllerAliasViolationException.phpnew+23 −0
- typo3/sysext/extbase/Classes/Configuration/PluginConfiguration.phpnew+140 −0
- typo3/sysext/extbase/Classes/Configuration/PluginControllerConfiguration.phpnew+62 −0
- typo3/sysext/extbase/Classes/Configuration/PluginProviderInterface.phpnew+25 −0
- typo3/sysext/extbase/Classes/Configuration/PluginRegistry.php2new+205 −0
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −30
- typo3/sysext/indexed_search/Configuration/Extbase/Plugins.php2new+17 −0
- typo3/sysext/indexed_search/ext_localconf.php+0 −8
Review log 56
-
Alexander Schnitzler uploaded patch set 1 02/23/20, 15:33
-
TYPO3com voted on patch set 1 V -1 02/23/20, 15:48 Completed build in 14m 41s on Sun, 23 Feb, 03:48 PM Test Summary: 45 of 72070 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-570
-
Daniel Siepmann commented on patch set 1 10/26/20, 11:14
PluginRegistry.php:102UnresolvedIn combination with the check and exception within `addControllerConfiguration()` it is not possible to change a controller configuration from another extension afterwards. Maybe we should collect the data from all configuration files first, and then build the objects once all files were parsed and merged? Otherwise I would guess we should adjust this method here and check if a matching pluginConfigurationObject already exists and extend the public API to alter the configuration, which sounds less nice.Plugins.php:5UnresolvedI would like to see the "default combination" as a separate configuration option. That way one could overrule this in another extension by setting that option.Plugins.php:12UnresolvedWhy should we use `null` as well as arrays, what's wrong with an empty array? -
Benni Mack wrote 11/29/21, 10:03
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:12
-
Alexander Schnitzler abandoned the change 04/01/23, 17:15
PluginRegistry.php:45Unresolved