Review main Abandoned

63396[TASK] Refactor extbase plugin registration

Alexander Schnitzler CR 0 V 0 Hard +473 −38 updated 04/01/23, 17:15

Commit message

tbw

todo:
- Decide whether PluginRegistry adds typoscript.
- If yes, it probably needs to be done via middleware (before TSFE)
- Patch currently only replaces plugin configuration, registration isn't
covered yet.

Review

  • Code review CR 0
  • Verified V 0

Files 8

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 02/23/20, 15:33

  2. TYPO3com voted on patch set 1 V -1 02/23/20, 15:48 Completed build in 14m 41s on Sun, 23 Feb, 03:48 PM Test Summary: 45 of 72070 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-570

  3. Daniel Siepmann commented on patch set 1 10/26/20, 11:14

    PluginRegistry.php:45 Unresolved

    We also could trigger it through Services.php to have this once during "compile time", just like many other things? But that would only work if ext_localconf.php are also loaded during that run, not sure about that. I even don't see a dependency to TSFE, as the API adds the default TypoScript which should be added before TSFE to allow TSFE to grab the TypoScript. Or is there some reason to not use that core API anymore?

    PluginRegistry.php:102 Unresolved

    In combination with the check and exception within `addControllerConfiguration()` it is not possible to change a controller configuration from another extension afterwards. Maybe we should collect the data from all configuration files first, and then build the objects once all files were parsed and merged? Otherwise I would guess we should adjust this method here and check if a matching pluginConfigurationObject already exists and extend the public API to alter the configuration, which sounds less nice.

    Plugins.php:5 Unresolved

    I would like to see the "default combination" as a separate configuration option. That way one could overrule this in another extension by setting that option.

    Plugins.php:12 Unresolved

    Why should we use `null` as well as arrays, what's wrong with an empty array?
  4. Benni Mack wrote 11/29/21, 10:03

    Change destination moved from master to main
  5. Benni Mack updated the commit message in patch set 2 11/29/21, 13:12

  6. Alexander Schnitzler abandoned the change 04/01/23, 17:15