Review main Merged

63399[BUGFIX] Cast to prevent PHP TypeError when using sqlite

Daniel Siepmann CR +2 V +2 Easy +3 −3 updated 02/24/20, 09:53

Commit message

sqlite3 doesn't return casted values right now, everything is a string.
Some methods require integers, e.g. uid of a record. In order to prevent
TypeError due to mismatch, values are casted to integer.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Markus Klein +1
    • Björn Jacob +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Markus Klein +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Daniel Siepmann uploaded patch set 1 02/24/20, 09:07

  2. Georg Ringer voted on patch set 1 V +1 CR +1 02/24/20, 09:07

  3. Daniel Siepmann uploaded patch set 2 02/24/20, 09:08

  4. Björn Jacob voted on patch set 2 CR +1 02/24/20, 09:11

  5. Markus Klein voted on patch set 2 V +1 CR +1 02/24/20, 09:14

  6. TYPO3com voted on patch set 1 V -1 02/24/20, 09:17 Completed build in 01m 02s on Mon, 24 Feb, 09:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-604

  7. Christian Eßl voted on patch set 2 V +1 CR +1 02/24/20, 09:30

  8. TYPO3com voted on patch set 2 V +1 02/24/20, 09:47 Completed build in 31m 02s on Mon, 24 Feb, 09:47 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-605

  9. Claus Due commented on patch set 2 V +1 CR +1 02/24/20, 09:47

    Take +1 verified here as "does not break mysql compat". Currently not able to test on sqlite.
  10. Georg Ringer voted on patch set 2 V +2 CR +2 02/24/20, 09:53

  11. Georg Ringer merged patch set 3 02/24/20, 09:53