Review 9.5 Merged

63404[DOCS] Add example for RadioButton/MultiCheckbox

TYPO3com CR +2 V +2 Easy +6 −0 updated 02/25/20, 08:30

Commit message

Add example for elements of type RadioButton/MultiCheckbox.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Björn Jacob +1

Issues 1

Files 1

Review log 1520

  1. TYPO3com uploaded patch set 1 02/24/20, 13:04

  2. TYPO3com voted on patch set 1 V +1 02/24/20, 13:43 Completed build in 18m 50s on Mon, 24 Feb, 01:43 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-79

  3. Björn Jacob updated the commit message in patch set 2 02/24/20, 17:20

  4. Oli Bartsch commented on patch set 2 CR -1 02/24/20, 17:30

    Commit messages states out this is for master but the patch is actually for 9.5. Does this also affect master and should be merged there first? Otherwise the commit message has to be adjusted.
  5. TYPO3com voted on patch set 2 V -1 02/24/20, 17:38 Completed build in 12m 46s on Mon, 24 Feb, 05:38 PM Test Summary: 1 of 74951 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-80

  6. Björn Jacob commented on patch set 2 02/24/20, 18:03

    There is another patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63403/ IMHO we should get this one in for master an v9. We are not working on v8 docs anymore. Too much work when it comes to backporting.
  7. Oli Bartsch commented on patch set 2 02/24/20, 18:04

    > Patch Set 2: > > There is another patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63403/ > > IMHO we should get this one in for master an v9. We are not working on v8 docs anymore. Too much work when it comes to backporting. Oke so close this one and manually backport the other one after merge?
  8. Björn Jacob updated the commit message in patch set 3 02/24/20, 18:04

  9. Björn Jacob commented on patch set 3 02/24/20, 18:05

    Changed to 9.5. We do have a different folder structure in master. Let's create a new patch for master.
  10. TYPO3com voted on patch set 3 V +1 02/24/20, 18:16 Completed build in 11m 31s on Mon, 24 Feb, 06:16 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-81

  11. Oli Bartsch commented on patch set 3 CR +1 02/24/20, 18:19

    > Patch Set 3: > > Changed to 9.5. We do have a different folder structure in master. Let's create a new patch for master. All right.
  12. Georg Ringer voted on patch set 3 V +1 CR +1 02/24/20, 21:08

  13. Björn Jacob voted on patch set 3 V +1 CR +1 02/24/20, 22:52

  14. Georg Ringer voted on patch set 3 V +2 CR +2 02/24/20, 22:55

  15. Georg Ringer commented on patch set 3 CR -2 02/25/20, 07:05

    björn will do master change first, this one blocked until then
  16. Ralf Zimmermann updated the commit message in patch set 4 02/25/20, 07:24

  17. Björn Jacob voted on patch set 4 V +1 CR +1 02/25/20, 08:18

  18. Georg Ringer voted on patch set 4 V +2 CR +2 02/25/20, 08:20

  19. Georg Ringer merged patch set 5 02/25/20, 08:21

  20. TYPO3com voted on patch set 4 V +1 02/25/20, 08:30 Completed build in 1h 06m 09s on Tue, 25 Feb, 08:30 AM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-82