Review main Merged

63411[BUGFIX] Keep old behaviour of image collection for admin panel

Daniel Siepmann CR +2 V +2 Easy +1 −2 updated 02/25/20, 12:37

Commit message

The existing behaviour was changed when introducing the AssetCollector.
The existing variable $imagesOnPage was overwritten with all information
from collected media. Originally only specific information were added.

Providing all information lead to closures ending up in serialization of
information during storing in cache.

This patch reverts back to original behaviour, only necessary
information are added.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
    • Christian Eßl +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
    • Christian Eßl +1
    • Susi Moog +1
    • TYPO3com +1 CI

Files 1

Review log 1017

  1. Daniel Siepmann uploaded patch set 1 02/25/20, 11:24

  2. TYPO3com voted on patch set 1 V -1 02/25/20, 11:25 Completed build in 23s on Tue, 25 Feb, 11:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-694

  3. Christian Eßl voted on patch set 1 V +1 CR +1 02/25/20, 11:27

  4. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 02/25/20, 11:30

  5. Daniel Goerz voted on patch set 1 CR +1 02/25/20, 11:32

  6. Oliver Hader voted on patch set 1 V +1 CR +1 02/25/20, 11:36

  7. TYPO3com commented on patch set 1 02/25/20, 11:38 Completed build in 09m 01s on Tue, 25 Feb, 11:38 AM Test Summary: 45530 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-695

  8. TYPO3com commented on patch set 1 02/25/20, 11:56 Completed build in 32m 01s on Tue, 25 Feb, 11:56 AM Test Summary: 62426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-694

  9. TYPO3com voted on patch set 1 V +1 02/25/20, 11:59 Completed build in 38m 30s on Tue, 25 Feb, 11:59 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-695

  10. Oli Bartsch voted on patch set 1 CR +1 02/25/20, 12:00

  11. TYPO3com voted on patch set 1 V -1 02/25/20, 12:08 Completed build in 1h 15m 29s on Tue, 25 Feb, 12:08 PM Test Summary: 66322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-694

  12. Andreas Kienast voted on patch set 1 V +1 CR +1 02/25/20, 12:25

  13. Susi Moog voted on patch set 1 V +1 CR +1 02/25/20, 12:25

  14. TYPO3com commented on patch set 1 02/25/20, 12:27 Completed build in 2h 17m 49s on Tue, 25 Feb, 12:27 PM Test Summary: 69442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-694

  15. Oliver Hader voted on patch set 1 V +2 CR +2 02/25/20, 12:32

  16. TYPO3com voted on patch set 1 V +1 02/25/20, 12:36 Completed build in 3h 29m 56s on Tue, 25 Feb, 12:36 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-694

  17. Oliver Hader merged patch set 2 02/25/20, 12:37