Review main Merged

63437[BUGFIX] Prevent TypeError in AssetCollector related ViewHelpers

Oli Bartsch CR +2 V +2 Easy +8 −2 updated 02/26/20, 16:04

Commit message

The two new ViewHelpers `CssViewHelper` and `ScriptViewHelper`
automatically render the content of their body if no source file
is supplied in the ViewHelpers argument. However if the body is
empty, NULL is passed to the AssetCollectors add inline code functions.
This leads to a TypeError as these parameters are type hinted.

Therefore the body content is now checked before
the methods get called to prevent passing NULL or an empty string.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2