Review main Merged

63439[TASK] use strict type comparison for isValueSelected

TYPO3com CR +2 V +2 Normal +92 −13 updated 02/28/20, 08:38

Commit message

\TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper::isSelected
uses a strict type comparison but the OptionViewHelper does not.

This resulted in funny results when the values were convertable to int
like this:
var_dump(in_array(1, ['1-2'])); // prints bool(true)

The value is now converted to a string, just like in the
SelectViewHelper, and then strictly compared.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2