Review main Merged

63481[TASK] Remove superfluous isset checks

Alexander Schnitzler CR +2 V +2 Easy +27 −9 updated 03/02/20, 11:18

Commit message

phpstan reported superfluous usages of isset checks for
variables that are defined and whose type is more
specifically checked in the same condition.

Some reported errors of phpstan have been ignored for now
as they are considered false positives and which will be
tackled once there is more type safety in the context of
those reported errors to be able to properly replace the
isset checks.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9